fix(i18n): replace hardcoded strings in ProfilePopupLayout with i18n …#2944
Merged
StageGuard merged 2 commits intoApr 28, 2026
Merged
Conversation
Him188
approved these changes
Apr 7, 2026
auto-merge was automatically disabled
April 8, 2026 10:44
Head branch was pushed to by a user without write access
Him188
approved these changes
Apr 9, 2026
Contributor
Author
Contributor
Author
|
CI failure on This PR only modifies i18n strings ( Could you re-run CI? Thanks. |
wellorbetter
force-pushed
the
fix/issue-2938-profile-popup-i18n
branch
from
3fecefd to
d9643cc
Compare
…resources open-ani#2938 - Add 7 new string keys for the account popup (not_logged_in, edit_profile, login_register, logout, logout_confirm, logout_button, cancel) - Provide translations in en, zh-CN, zh-HK, zh-TW - Update ProfilePopupLayout.kt and ProfilePopup.kt to use stringResource(Lang.xxx)
wellorbetter
force-pushed
the
fix/issue-2938-profile-popup-i18n
branch
from
d9643cc to
aa58194
Compare
Contributor
Author
|
@Him188 Hi, can you review this pr & re-triger this CI? |
ChouChiu
approved these changes
Apr 28, 2026
This comment has been minimized.
This comment has been minimized.
Member
是我点的 |
Contributor
Author
|
CI passed. Could you merge this change? Thanks. @StageGuard |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded Chinese strings in ProfilePopupLayout and ProfilePopup with proper i18n resource references.
Closes #2938
Reasoning
ProfilePopupLayout.kt and ProfilePopup.kt contained hardcoded Chinese strings ("未登录", "编辑个人资料", "登录 / 注册", "设置",
"退出登录", "确定要退出登录吗?", "取消"). These have been replaced with stringResource(Lang.xxx) calls following the existing
pattern in the codebase.
New string keys added under the settings_account_popup_* namespace, with translations provided for:
zh-MO, zh-SG, and zh locales are auto-generated by the populateStringsLocales Gradle task and are not committed.
Type of change
✅ Bug fix
❌ New feature / Enhancement (i18n support for account popup strings)
❌ Breaking change
❌ Refactor
❌ Performance
❌ Style
❌ Docs
❌ Chore